Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename Aircraft.Wing.MOUNTING_TYPE to Aircraft.Wing.MOUNT_LOCATION #643

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

rename Aircraft.Wing.MOUNTING_TYPE to Aircraft.Wing.MOUNT_LOCATION #643

wants to merge 17 commits into from

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Jan 13, 2025 •
edited
Loading

Summary

This is a very simple PR. The variable Aircraft.Wing.MOUNTING_TYPE is the wing location on fuselage between 0 and 1. Rename it to Aircraft.Wing.MOUNT_LOCATION

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

ehariton
ehariton approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ehariton ehariton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update description definition slightly to include that values between 0 and 1 are acceptable.

@xjjiang xjjiang closed this Jan 29, 2025
@xjjiang xjjiang deleted the mount_location branch January 29, 2025 22:43
@xjjiang xjjiang restored the mount_location branch January 29, 2025 22:50
@xjjiang xjjiang reopened this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkirk5 jkirk5 jkirk5 approved these changes

@ehariton ehariton ehariton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjjiang @ehariton @jkirk5